Add basic support for .heic files #519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimn
reviewed
Jul 15, 2024
| if hasattr(img, "_getexif") and callable(img._getexif): | ||
| exif = img._getexif() | ||
| elif "exif" in img.info: | ||
| exif = img.getexif()._get_merged_dict() |
There was a problem hiding this comment.
img._getexif() is an alias for img.getexif()._get_merged_dict() so we can probably switch to the public methods, which I think are supported since a long time ? (Our min version of pillow is 8.0 currently)
saimn
reviewed
Sep 5, 2024
| @@ -264,7 +264,7 @@ def exif(self): | |||
| datetime_format = self.settings["datetime_format"] | |||
| return ( | |||
| get_exif_tags(self.raw_exif, datetime_format=datetime_format) | |||
| if self.raw_exif and self.src_ext in (".jpg", ".jpeg") | |||
| if self.raw_exif and self.src_ext in (".jpg", ".jpeg", ".heic") | |||
There was a problem hiding this comment.
The extension list here and below should also include ".heif" I guess ?
Also, those extensions should be recognized only if pillow-heif is available, so might be better to store this list somewhere where it can be imported (in the image module ?) and reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.